Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused RPCs and disable reconfiguration #2970

Merged
merged 4 commits into from
Oct 26, 2024
Merged

Remove unused RPCs and disable reconfiguration #2970

merged 4 commits into from
Oct 26, 2024

Conversation

shengquan-ni
Copy link
Collaborator

@shengquan-ni shengquan-ni commented Oct 25, 2024 •
edited
Loading

As discussed in #2950, we plan to remove obsolete RPCs and reconfiguration-related RPCs in this PR. We will bring reconfiguration back after #2950.

Removed:

  1. QueryCurrentInputTuple.
  2. ShutdownDPThread.

Disabled, will be added later:

  1. Reconfiguration.
  2. UpdateExecutor.
  3. UpdateMultipleExecutors.

@shengquan-ni shengquan-ni self-assigned this Oct 25, 2024
Yicong-Huang
Yicong-Huang approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@Yicong-Huang Yicong-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shengquan-ni shengquan-ni merged commit a2aaf66 into master Oct 26, 2024
9 checks passed
@shengquan-ni shengquan-ni deleted the shengquan-remove-rpc branch October 26, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yicong-Huang Yicong-Huang Yicong-Huang approved these changes

Assignees

@shengquan-ni shengquan-ni

Labels
engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shengquan-ni @Yicong-Huang